Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download a fresh list of compiler binaries if out of date #686

Merged
merged 3 commits into from
Dec 4, 2023
Merged

download a fresh list of compiler binaries if out of date #686

merged 3 commits into from
Dec 4, 2023

Conversation

OmarTawfik
Copy link
Contributor

Makes sure we fetch new versions when they are released.

@OmarTawfik OmarTawfik requested a review from a team as a code owner December 2, 2023 04:48
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b7161a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Xanewok
Xanewok suggested changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a one minor issue that I'd like to address since we're changing this code (please bear with me 🙏 )

crates/solidity/testing/solc/src/utils/binaries.rs Show resolved Hide resolved
@OmarTawfik OmarTawfik force-pushed the update-ood-binaries-list branch from dff1a95 to d1236d0 Compare December 3, 2023 14:17
@OmarTawfik OmarTawfik requested a review from Xanewok December 3, 2023 14:18
@OmarTawfik OmarTawfik force-pushed the update-ood-binaries-list branch from d1236d0 to b7161a5 Compare December 4, 2023 12:11
Xanewok
Xanewok approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@Xanewok Xanewok added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit e37d4b5 Dec 4, 2023
2 checks passed
@Xanewok Xanewok deleted the update-ood-binaries-list branch December 4, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @Xanewok